Project

General

Profile

Bug #6368

Remove superfluous statement

Added by Richard Yao almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Matthew Ahrens
Category:
zfs - Zettabyte File System
Start date:
2015-10-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

Clang's static analyzer reported that the value assigned to pcksum is
never used. That is because we initialize both zc and pcksum to {{ 0 }}
and then do `pcksum = zc;`. That is fairly pointless. However, it has
the effect of generating a false positive in Clang's static analyzer.
Since noise from false positives can obscure real issues, we fix it
anyway.

https://github.com/zfsonlinux/zfs/commit/2024041b6c5134a925a33c10eff24a47ecb541a6

Reviewed-by: Ned Bass <>
Reviewed-by: Brian Behlendorf <>
Reviewed-by: Matthew Ahrens <>

History

#1

Updated by Electric Monk almost 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 7c5a457e2a179dbaf12f243b90fdb520254e0c18

commit  7c5a457e2a179dbaf12f243b90fdb520254e0c18
Author: Richard Yao <ryao@gentoo.org>
Date:   2015-11-01T05:37:04.000Z

    6368 Remove superfluous statement
    Reviewed-by: Ned Bass <bass6@llnl.gov>
    Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
    Reviewed by: Will Andrews <will@freebsd.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF