Project

General

Profile

Actions

Bug #6436

closed

156 lint errors in common/crypto/edonr/edonr.c

Added by Gary Mills over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2015-11-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

When I did a build with lint, I got 156 lint errors in mail_msg, all from edonr.c . They look like this:

"../../../common/crypto/edonr/edonr.c", line 268: warning: variable may be used before set: swp10 (E_VAR_USED_BEFORE_SET)
"../../../common/crypto/edonr/edonr.c", line 268: warning: variable may be used before set: swp11 (E_VAR_USED_BEFORE_SET)
"../../../common/crypto/edonr/edonr.c", line 268: warning: variable may be used before set: swp12 (E_VAR_USED_BEFORE_SET)
...
"/dpool/export/home/mills/Downloads/code/illumos-gate/usr/src/common/crypto/edonr/edonr.c", line 709: warning: set but not used in function: l in EdonRFinal (E_FUNC_SET_NOT_USED)
"/dpool/export/home/mills/Downloads/code/illumos-gate/usr/src/common/crypto/edonr/edonr.c", line 709: warning: variable unused in function: s4 in EdonRFinal (E_FUNC_VAR_UNUSED)

Here's the distribution of lint error types:

  96 E_VAR_USED_BEFORE_SET
  30 E_FUNC_SET_NOT_USED
  22 E_FUNC_VAR_UNUSED
   8 E_BAD_PTR_CAST_ALIGN
Actions #1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 8b2aab4fb2ee21a9076eb25068178246a12470b7

commit  8b2aab4fb2ee21a9076eb25068178246a12470b7
Author: Gary Mills <gary_mills@fastmail.fm>
Date:   2016-03-14T19:08:03.000Z

    6436 156 lint errors in common/crypto/edonr/edonr.c
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions

Also available in: Atom PDF