Project

General

Profile

Actions
Copy link

Bug #6447

closed

handful of nvpair cleanups

Added by Josef Sipek almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Josef Sipek
Category:
lib - userland libraries
Start date:
2015-11-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

I got a patch from someone who uses nvpair code outside of illumos. It fixes a couple of gcc warnings/bugs for him.

  1. silence uninitialized use warnings
  2. add parentheses around assignment used as truth value
  3. fix printf format specifier (ll is for integers only)
  4. strstr, strspn, strcspn, and strcmp are declared in string.h, not strings.h.
  5. avoid scanning integer into boolean variable
Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed

git commit 759e89be359f2af635e4122d147df56bce948773

commit  759e89be359f2af635e4122d147df56bce948773
Author: Steve Dougherty <sdougherty@barracuda.com>
Date:   2015-11-17T23:19:53.000Z

    6447 handful of nvpair cleanups
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF