dmake should cool its close(2) jets
I was doing some dtracing while waiting for a build to finish and discovered that dmake makes an excessive number of close(2) calls. It's a case of "call close in a loop until maxfd" logic during io redirection when spawning a job. When replaced with closefrom(), I saved almost 40% (77 mins cut down to 47 mins) on a full nightly run of SmartOS.
Additional details here: https://smartos.org/bugview/OS-4940
Updated by Electric Monk about 5 years ago
- Status changed from New to Closed
commit da2c0e64794ff584dca660fcc94a444dcc0d6c0b Author: Patrick Mooney <email@example.com> Date: 2015-11-14T16:47:05.000Z 6455 dmake should cool its close(2) jets Reviewed by: Robert Mustacchi <firstname.lastname@example.org> Reviewed by: Jason King <email@example.com> Reviewed by: Adam Števko <firstname.lastname@example.org> Reviewed by: Albert Lee <email@example.com> Reviewed by: Garrett D'Amore <firstname.lastname@example.org> Approved by: Garrett D'Amore <email@example.com>