ucopystr can't find its way home
The amd64 version of the ucopystr routine can end up causing an 8-byte stack entry to be lost and result in a rather confused system. The problem is that ucopystr ends up doing a jmp to do_copystr, from which it returns from. do_copystr is part of copystr. copystr pushes on a frame pointer; however, ucopystr does not. This means that when we end up leaving do_copystr we do a leave and a ret.
Because ucopystr does not push on a frame pointer, that results in the leave from do_copystr losing the return address and returning to something else entirely.
Updated by Electric Monk almost 6 years ago
- Status changed from New to Closed
commit cbff3abd8ecaa7b8e6a47457e0a5e562dbfc2cad Author: Robert Mustacchi <firstname.lastname@example.org> Date: 2015-11-30T18:47:57.000Z 6457 ucopystr can't find its way home Reviewed by: Patrick Mooney <email@example.com> Reviewed by: Josef 'Jeff' Sipek <firstname.lastname@example.org> Reviewed by: Garrett D'Amore <email@example.com> Reviewed by: Toomas Soome <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>