Project

General

Profile

Bug #6467

nvme version number check is broken

Added by Hans Rosenfeld about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
2015-11-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

The version check in nvme_init() is broken, making it completely ineffective. This was found on a Samsung SSD conforming to NVMe spec 1.1, which attached fine instead of bailing out early in attach.

History

#1

Updated by Electric Monk about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 2797e2b9652d58879341d37f99d68c4db73672fd

commit  2797e2b9652d58879341d37f99d68c4db73672fd
Author: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Date:   2015-11-19T22:50:44.000Z

    6467 nvme version number check is broken
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF