Project

General

Profile

Bug #6518

pkgadm message format is inconsistent with actual usage

Added by Alexander Pyhalov almost 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2015-12-16
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

If we enable lint for pkgadm, we can see messages like this:

"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 810: warning: function argument type inconsistent with format: log_msg(arg 3) unsigned long  and (format) int  in lock.c(810) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 810: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(810) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 923: warning: function argument type inconsistent with format: log_msg(arg 3) unsigned long  and (format) int  in lock.c(923) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 923: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(923) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 962: warning: function argument type inconsistent with format: fprintf(arg 7) long  and (format) int  in lock.c(962) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1027: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1027) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1027: warning: function argument type inconsistent with format: log_msg(arg 5) unsigned long  and (format) int  in lock.c(1027) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1663: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1663) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1772: warning: function argument type inconsistent with format: log_msg(arg 4) long long  and (format) int  in lock.c(1772) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1810: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1810) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1810: warning: function argument type inconsistent with format: log_msg(arg 5) unsigned long  and (format) int  in lock.c(1810) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1833: warning: function argument type inconsistent with format: log_msg(arg 3) unsigned long  and (format) int  in lock.c(1833) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1833: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1833) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1931: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1931) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1931: warning: function argument type inconsistent with format: log_msg(arg 5) unsigned long  and (format) int  in lock.c(1931) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1946: warning: function argument type inconsistent with format: log_msg(arg 3) unsigned long  and (format) int  in lock.c(1946) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1946: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1946) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1971: warning: function argument type inconsistent with format: log_msg(arg 3) long long  and (format) long  in lock.c(1971) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1971: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1971) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1971: warning: function argument type inconsistent with format: log_msg(arg 5) unsigned long  and (format) int  in lock.c(1971) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1979: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(1979) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 1979: warning: function argument type inconsistent with format: log_msg(arg 5) long long  and (format) long  in lock.c(1979) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 2004: warning: function argument type inconsistent with format: log_msg(arg 3) unsigned long  and (format) int  in lock.c(2004) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 2004: warning: function argument type inconsistent with format: log_msg(arg 4) unsigned long  and (format) int  in lock.c(2004) (E_BAD_FORMAT_ARG_TYPE2)
"/export/home/alp/srcs/illumos-gate/usr/src/cmd/svr4pkg/pkgadm/lock.c", line 2004: warning: function argument type inconsistent with format: log_msg(arg 5) long long  and (format) long  in lock.c(2004) (E_BAD_FORMAT_ARG_TYPE2)

This hints us that gettext defines in pkgadm_msgs.h are incorrect

Also available in: Atom PDF