Properly handle updates of variably-sized SA entries.
During the update process in sa_modify_attrs(), the sizes of existing
variably-sized SA entries are obtained from sa_lengths. The case where
a variably-sized SA was being replaced neglected to increment the index
into sa_lengths, so subsequent variable-length SAs would be rewritten
with the wrong length. This patch adds the missing increment operation
so all variably-sized SA entries are stored with their correct lengths.
Another problem was that index into attr_desc was increased even when
an attribute was removed. If that attribute was not the last attribute,
then the last attribute was lost.
Updated by Electric Monk over 6 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit e7e978b1f75353cb29673af9b35453c20c2827bf Author: Andriy Gapon <firstname.lastname@example.org> Date: 2015-12-22T05:37:35.000Z 6529 Properly handle updates of variably-sized SA entries. Reviewed by: Brian Behlendorf <email@example.com> Reviewed by: Matthew Ahrens <firstname.lastname@example.org> Reviewed by: Ned Bass <email@example.com> Reviewed by: Tim Chase <firstname.lastname@example.org> Approved by: Gordon Ross <email@example.com>