Project

General

Profile

Actions

Bug #6529

closed

Properly handle updates of variably-sized SA entries.

Added by Matthew Ahrens almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2015-12-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

During the update process in sa_modify_attrs(), the sizes of existing
variably-sized SA entries are obtained from sa_lengths[]. The case where
a variably-sized SA was being replaced neglected to increment the index
into sa_lengths[], so subsequent variable-length SAs would be rewritten
with the wrong length. This patch adds the missing increment operation
so all variably-sized SA entries are stored with their correct lengths.

Another problem was that index into attr_desc[] was increased even when
an attribute was removed. If that attribute was not the last attribute,
then the last attribute was lost.


Related issues

Related to illumos gate - Bug #6434: sa_find_sizes() may compute wrong SA header sizeClosedMatthew Ahrens2015-11-05

Actions
Actions

Also available in: Atom PDF