Project

General

Profile

Bug #6530

login/login.c display_last_login_time(void) should implement better checks for data

Added by Toomas Soome almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
cmd - userland programs
Start date:
2015-12-22
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

console login shows: Last login: (null) from 192.168.225.1

apparently this "(null)" is NULL pointer returned by ctime().

apparently the login trusts too much the content from lastlog; the login/login.c display_last_login_time(void) should implement better checks for data.

#1

Updated by Toomas Soome almost 5 years ago

Apparently the issue itself is actually triggered by incorrect 64bit time_t management in dilos, but I still think the input data should be verified properly.

#2

Updated by Toomas Soome almost 5 years ago

  • Status changed from New to Closed

apparently 6057 does take care of this issue.

Also available in: Atom PDF