Project

General

Profile

Actions
Copy link

Bug #6577

closed

zfs_copies_004_neg fails trying to expand wildcard characters

Added by Yuri Pankov over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Yuri Pankov
Category:
tests
Start date:
2016-01-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

zfs_copies_004_neg erroneously uses wildcard characters (? *) as one of the possible values for copies property, and if you happen to have a file with a name that is a valid value for "copies" property (eg, 1), the test case fails as shown below:

ASSERTION: Verify that copies property cannot be set to any value other than 1,2 or 3
SUCCESS: /usr/sbin/zfs create -o copies=0 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=0 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=0 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=0 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=01 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=01 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=01 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=01 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=02 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=02 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=02 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=02 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=03 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=03 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=03 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=03 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=0 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=0 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=0 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=0 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=-1 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=-1 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=-1 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=-1 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=-2 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=-2 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=-2 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=-2 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=-3 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=-3 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=-3 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=-3 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=10 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=10 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=10 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=10 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=20 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=20 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=20 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=20 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=30 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=30 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=30 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=30 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=4 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=4 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=4 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=4 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=5 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=5 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=5 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=5 testpool.100645/testvol100645 exited 1
SUCCESS: /usr/sbin/zfs create -o copies=6 testpool.100645/testfs1.100645 exited 1
SUCCESS: /usr/sbin/zfs create -V 150m -o copies=6 testpool.100645/testvol1100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=6 testpool.100645/testfs.100645 exited 1
SUCCESS: /usr/sbin/zfs set copies=6 testpool.100645/testvol100645 exited 1

ERROR: /usr/sbin/zfs create -o copies=1 testpool.100645/testfs1.100645 unexpectedly exited 0

We clearly don't have "1" in the array of bad values, so it's coming from "?" expansion. The fix is to remove the wildcard characters from bad values list.

Actions
Copy link
 #1

Updated by Electric Monk about 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 50 to 100

git commit 964a6bd0f9365bb057bceb3cf813be3dbb8de2bf

commit  964a6bd0f9365bb057bceb3cf813be3dbb8de2bf
Author: Yuri Pankov <yuri.pankov@nexenta.com>
Date:   2016-02-25T05:58:20.000Z

    6577 zfs_copies_004_neg fails trying to expand wildcard characters
    Reviewed by: John Kennedy <john.kennedy@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF