Actions
Bug #6580
closedzfs-tests use undefined variable WRAPPER
Start date:
2016-01-26
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
Description
Several test cases in zfs-tests use the variable WRAPPER, which doesn't seem to be defined anywhere:
usr/src/test/zfs-tests/tests/functional/utils_test/utils_test_007_pos.ksh:elif [[ $WRAPPER == "smi" ]]; then usr/src/test/zfs-tests/tests/functional/cache/cache.kshlib: if [[ $WRAPPER == *"smi"* ]]; then usr/src/test/zfs-tests/tests/functional/slog/slog.kshlib: if [[ $WRAPPER == *"smi"* ]]; then usr/src/test/zfs-tests/tests/functional/inuse/inuse_007_pos.ksh: if [[ $WRAPPER == *"smi"* && \ usr/src/test/zfs-tests/tests/functional/inuse/inuse_003_pos.ksh: if [[ $WRAPPER == *"smi"* && $disk == ${saved_disk} ]]; then usr/src/test/zfs-tests/tests/functional/inuse/inuse_006_pos.ksh: if [[ $WRAPPER == *"smi"* && \ usr/src/test/zfs-tests/tests/functional/inuse/inuse_008_pos.ksh: if [[ $WRAPPER == *"smi"* && \ usr/src/test/zfs-tests/tests/functional/inuse/inuse_009_pos.ksh: if [[ $WRAPPER == *"smi"* && \ usr/src/test/zfs-tests/tests/functional/inuse/inuse_005_pos.ksh: if [[ $WRAPPER == *"smi"* && \ usr/src/test/zfs-tests/tests/functional/inuse/inuse_001_pos.ksh:if [[ $WRAPPER == *"smi"* ]]; then usr/src/test/zfs-tests/tests/functional/grow_replicas/grow_replicas.cfg:if [[ $WRAPPER != *"smi"* ]]; then
This looks like leftovers from STC conversion. If that's not the case and it's actually usable, we need to document it in the README.
Updated by Yuri Pankov over 6 years ago
- Status changed from New to In Progress
- Assignee set to Yuri Pankov
- Difficulty changed from Medium to Bite-size
- Tags deleted (
needs-triage)
Updated by Electric Monk over 6 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit 9498083eeaed1aacdde41369b7fa6f3b84870791
commit 9498083eeaed1aacdde41369b7fa6f3b84870791 Author: Yuri Pankov <yuri.pankov@gmail.com> Date: 2016-04-10T03:31:14.000Z 6580 zfs-tests use undefined variable WRAPPER Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Matthew Ahrens <mahrens@delphix.com>
Actions