Project

General

Profile

Bug #6639

uhci_qh walker contains whacky boolean logic

Added by Rich Lowe over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2016-02-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

     /* Make sure next element is a QH.  If a TD, stop.  */
    if (!  ((((queue_head_t *)wsp->walk_data)->link_ptr) & HC_QUEUE_HEAD)
        == HC_QUEUE_HEAD)  {

Is convoluted and unlikely to do what's desired.

History

#1

Updated by Electric Monk over 4 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Closed

git commit a7317ceb814150d472383df8b987d7e3282ea15b

commit  a7317ceb814150d472383df8b987d7e3282ea15b
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2016-02-13T19:10:03.000Z

    6639 uhci_qh walker contains whacky boolean logic
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF