Project

General

Profile

Actions
Copy link

Bug #6645

closed

sgsmsg relies on undefined behaviour of loop-scoped variables

Added by Rich Lowe over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
-
Start date:
2016-02-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

sgsmsg relies on a variable scoped within a loop and left uninitialized to retain its value across iterations of the loop as if it were in the outer scope. That's pretty much always true, but is also disgusting. Let's not.

Actions
Copy link
 #1

Updated by Rich Lowe over 5 years ago

  • Subject changed from sgsmsg relies on behaviour of loop-scoped variables to sgsmsg relies on undefined behaviour of loop-scoped variables
Actions
Copy link
 #2

Updated by Electric Monk over 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit eae164eb03cbb004dcf9154f36352e62f693eb6c

commit  eae164eb03cbb004dcf9154f36352e62f693eb6c
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2016-02-14T21:10:44.000Z

    6645 sgsmsg relies on undefined behaviour of loop-scoped variables
    Reviewed by: Andy Stormont <andyjstormont@gmail.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF