Project

General

Profile

Bug #6674

sys/isa_defs.h shouldn't unconditionally define _ILP32

Added by Yuri Pankov over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2016-02-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Been playing with clang which defines _ILP32, so the stuff is failing with:

sys/isa_defs.h:330:9: error: '_ILP32' macro redefined [-Werror,-Wmacro-redefined]

The fix seems to be doing the same as done for _LP64 below.

History

#1

Updated by Yuri Pankov over 4 years ago

  • Description updated (diff)
#2

Updated by Yuri Pankov over 4 years ago

  • Status changed from New to Pending RTI
  • Assignee set to Yuri Pankov
  • % Done changed from 0 to 90
#3

Updated by Electric Monk about 4 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit d643a855cbd8c4fb4fe966406fa05dff70673597

commit  d643a855cbd8c4fb4fe966406fa05dff70673597
Author: Yuri Pankov <yuri.pankov@gmail.com>
Date:   2016-02-27T16:52:10.000Z

    6674 sys/isa_defs.h shouldn't unconditionally define _ILP32
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF