zfs list burning lots of time in dodefault() via dsl_prop_*
Flamegraphing "zfs list" commands suggests that there is unnecessary time being burnt in dodefault() – see https://us-east.manta.joyent.com/arekinath/public/zfs-flame3.html
dodefault() takes a string argument, the name of a ZFS property, then looks it up to get a zfs_prop_t using zfs_name_to_prop. However, in most of the places dodefault() is called, the zfs_prop_t is already known in the function calling. We can just pass it through and avoid wasting time here.
Updated by Electric Monk over 3 years ago
- Status changed from New to Closed
commit d09e4475f635b6f66ee68d8c17a32bba7be17c96 Author: Alex Wilson <firstname.lastname@example.org> Date: 2016-03-10T21:46:48.000Z 6681 zfs list burning lots of time in dodefault() via dsl_prop_* Reviewed by: Patrick Mooney <email@example.com> Reviewed by: Matthew Ahrens <firstname.lastname@example.org> Reviewed by: Dan McDonald <email@example.com> Approved by: Matthew Ahrens <firstname.lastname@example.org>