Project

General

Profile

Actions
Copy link

Bug #6681

closed

zfs list burning lots of time in dodefault() via dsl_prop_*

Added by Robert Mustacchi about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Alex Wilson
Category:
zfs - Zettabyte File System
Start date:
2016-02-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Flamegraphing "zfs list" commands suggests that there is unnecessary time being burnt in dodefault() – see https://us-east.manta.joyent.com/arekinath/public/zfs-flame3.html

dodefault() takes a string argument, the name of a ZFS property, then looks it up to get a zfs_prop_t using zfs_name_to_prop. However, in most of the places dodefault() is called, the zfs_prop_t is already known in the function calling. We can just pass it through and avoid wasting time here.

Actions
Copy link
 #1

Updated by Robert Mustacchi about 5 years ago

  • Subject changed from zfs list burning lots of time in dodefault() via dsl_prop_* to zfs list burning lots of time in dodefault() via dsl_prop_*
Actions
Copy link
 #2

Updated by Electric Monk about 5 years ago

  • Status changed from New to Closed

git commit d09e4475f635b6f66ee68d8c17a32bba7be17c96

commit  d09e4475f635b6f66ee68d8c17a32bba7be17c96
Author: Alex Wilson <alex.wilson@joyent.com>
Date:   2016-03-10T21:46:48.000Z

    6681 zfs list burning lots of time in dodefault() via dsl_prop_*
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Matthew Ahrens <mahrens@delphix.com>

Actions
Copy link

Also available in: Atom PDF