Project

General

Profile

Actions

Bug #6681

closed

zfs list burning lots of time in dodefault() via dsl_prop_*

Added by Robert Mustacchi over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2016-02-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Flamegraphing "zfs list" commands suggests that there is unnecessary time being burnt in dodefault() – see https://us-east.manta.joyent.com/arekinath/public/zfs-flame3.html

dodefault() takes a string argument, the name of a ZFS property, then looks it up to get a zfs_prop_t using zfs_name_to_prop. However, in most of the places dodefault() is called, the zfs_prop_t is already known in the function calling. We can just pass it through and avoid wasting time here.

Actions

Also available in: Atom PDF