Project

General

Profile

Actions
Copy link

Bug #6737

closed

pbchk checks unmodified files

Added by Matthew Ahrens over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Matthew Ahrens
Category:
tools - gate/build tools
Start date:
2016-03-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

pbchk attempts to detect which files have changed so that it can tell us which files to update copyright for. This ends up including all files that have been touched at all, including ones where all changes have been reverted. This can be resolved by squashing commits together in the git log, but fixing this in pbchk itself would be preferable.

Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit ad20b230af4d39149ceb8bf412ddc9ff0deff2e0

commit  ad20b230af4d39149ceb8bf412ddc9ff0deff2e0
Author: Paul Dagnelie <pcd@delphix.com>
Date:   2016-04-01T15:41:24.000Z

    6737 pbchk checks unmodified files
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Alex Reece <alex@delphix.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF