Project

General

Profile

Actions
Copy link

Bug #6753

closed

remove acpi_fw.h

Added by Toomas Soome over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
kernel
Start date:
2016-03-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

The usr/src/uts/i86pc/os/acpi_fw.h is dedicated header file for fakebop.c and lgrpplat.c defining instances of acpi tables, effectively duplicating the definitions already in place in acpica headers. Unfortunately it also means the acpi_fw.h is not current by itself nor in regard to acpica definitions.

acpi_fw.h showul be removed and headers provided by acpica should be used instead, making sure the early boot code is current in regard of acpica currently used by the kernel. Note, only structure definitions are used, as acpica itself is not available for very early boot code, the fakebop/lgrpplat implement their own methods to interpret the acpi tables.

reviewboard url: https://www.illumos.org/rb/r/177/

The principal rewrite is done, also some limited testing.

Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 7bc870e686dc02eed8049c71d916e03f1c233a1a

commit  7bc870e686dc02eed8049c71d916e03f1c233a1a
Author: Toomas Soome <tsoome@me.com>
Date:   2016-03-25T20:42:38.000Z

    6753 remove acpi_fw.h
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF