Project

General

Profile

Actions

Bug #6769

closed

bop_printf internal buffer is too small

Added by Toomas Soome over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2016-03-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

uts/i86pc/os/fakebop.c is using internal buffer to support bop_printf():

#define BUFFERSIZE 256
static char buffer[BUFFERSIZE];

As one debug message is reporting boot command line, the command line can get quite large due to property lists setup with -B switch, the buffer size 256 may not be big enough (I have seen this), cutting the long printout. I think 512 is safer value for buffer size and should cover the use cases better.

Actions #1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 28614c54e31c80fa6afc3ca7035a9eaa79fbaa63

commit  28614c54e31c80fa6afc3ca7035a9eaa79fbaa63
Author: Toomas Soome <tsoome@me.com>
Date:   2016-03-23T14:11:52.000Z

    6769 bop_printf internal buffer is too small
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions

Also available in: Atom PDF