Project

General

Profile

Actions

Bug #6854

closed

Set but not used in hat_sfmmu.c

Added by Gary Mills over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2016-04-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

During a lint build on the SPARC platform, these lint warnings appeared:

"../../../sfmmu/vm/hat_sfmmu.c", line 13239: warning: set but not used in function: hmeblkp in sfmmu_rm_large_mappings (E_FUNC_SET_NOT_USED)
"../../../sfmmu/vm/hat_sfmmu.c", line 8193: warning: set but not used in function: hmeblkp in hat_page_demote (E_FUNC_SET_NOT_USED)
"../../sfmmu/vm/hat_sfmmu.c", line 13239: warning: set but not used in function: hmeblkp in sfmmu_rm_large_mappings (E_FUNC_SET_NOT_USED)
"../../sfmmu/vm/hat_sfmmu.c", line 8193: warning: set but not used in function: hmeblkp in hat_page_demote (E_FUNC_SET_NOT_USED)

This file is only compiled on SPARC hardware. It's not compiled on x86 hardware. The warning seems to be a result of bug #6345, aka `remove xhat support'. The fix for this bug removed the code that used hmeblkp but left the variable and the function call that calculated it. In these two instances, the result is not used.

Actions #1

Updated by Electric Monk over 6 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 60 to 100

git commit 83b627dfe34874b2f849abe19fcd0723d99a7273

commit  83b627dfe34874b2f849abe19fcd0723d99a7273
Author: Gary Mills <gary_mills@fastmail.fm>
Date:   2016-04-11T05:26:51.000Z

    6854 Set but not used in hat_sfmmu.c
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions

Also available in: Atom PDF