Project

General

Profile

Bug #6879

incorrect endianness swap for drr_spill.drr_length in libzfs_sendrecv.c

Added by Matthew Ahrens over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2016-04-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

In libzfs_sendrecv, there's a typo:

case DRR_SPILL:
if (byteswap) {
drr->drr_u.drr_write.drr_length =
BSWAP_64(drr->drr_u.drr_spill.drr_length);
}

Instead of drr_write.drr_length, we should be assigning the result of the byteswap to drr_spill.drr_length.

History

#1

Updated by Electric Monk over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 20fea7a47472aceb64d3ed48cc2a3ea268bc4795

commit  20fea7a47472aceb64d3ed48cc2a3ea268bc4795
Author: Dan Kimmel <dan.kimmel@delphix.com>
Date:   2016-04-20T21:22:57.000Z

    6879 incorrect endianness swap for drr_spill.drr_length in libzfs_sendrecv.c
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF