Project

General

Profile

Actions

Bug #6925

open

webrev: difflines() must properly handle lines consisting of single dot

Added by Yuri Pankov over 6 years ago. Updated over 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
tools - gate/build tools
Start date:
2016-04-20
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Currently, difflines() skips to the next line consisting of single dot while processing Na and Nc cases, assuming that it's the end of current block - it shouldn't, and needs to correctly calculate the changed lines count (as done for, e.g. N,Nc and Nd cases). Current behavior breaks for e.g. man pages, where single dot line is pretty normal.

Actions #1

Updated by Yuri Pankov over 6 years ago

An example:

 Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/lofiadm.1m
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

    6602 lofi should support labeled devices

    Unexpected Error occurred reading `diff -e old/usr/src/man/man1m/lofiadm.1m new/usr/src/man/man1m/lofiadm.1m`: $?=0, err= 1

Actions

Also available in: Atom PDF