Project

General

Profile

Bug #6938

STMF kstat free is using an improper size for kmem_free().

Added by Dan McDonald almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
comstar - iSCSI/FC/SAS target
Start date:
2016-04-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

The registration portion of STMF calls kmem_alloc() with constants for LU kstats (STMF_KSTAT_LU_SZ) and for the port kstats (STMF_KSTAT_TGT_SZ). The corresponding kmem_free() calls, however, are both being fed the kstat's ks_data_size, which breaks on kmem_debug=0xf when ks_data_size is altered (legally, by the kstat subsystem).

#1

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3c9850a686c2fcba473e4f602616772c17c21dee

commit  3c9850a686c2fcba473e4f602616772c17c21dee
Author: Dan McDonald <danmcd@omniti.com>
Date:   2016-05-18T02:44:42.000Z

    6938 STMF kstat free is using an improper size for kmem_free().
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Approved by: Gordon Ross <gordon.ross@nexenta.com>

Also available in: Atom PDF