Project

General

Profile

Bug #6980

6902 causes zfs send to break due to 32-bit/64-bit struct mismatch

Added by Gernot Strasser almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2016-05-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

doing zfs send -i snap1 snap2 >testfile results in
internal error: Invalid argument
Abort (core dumped)

Related issues

Related to illumos gate - Feature #6902: speed up listing of snapshots if requesting name only and sorting by nameClosed2016-04-11

Actions

History

#1

Updated by Robert Mustacchi almost 4 years ago

The problem here is unfortunately straightforward. What's happened is that the zfs_cmd_t used to be bitness neutral. However, the change for 6902 added a uint8_t to the zfs_cmd_t but didn't ensure that it was 32-bit / 64-bit clean. This then causes various members to now be off and in our tracing this showed that we were trying to pass a value of zero to holding a dataset snapshot.

#2

Updated by Robert Mustacchi almost 4 years ago

  • Subject changed from Either 6513 or 6902 seem to break zfs send -i to 6902 causes zfs send to break due to 32-bit/64-bit struct mismatch
#3

Updated by Gernot Strasser almost 4 years ago

  • Related to Feature #6902: speed up listing of snapshots if requesting name only and sorting by name added
#4

Updated by Electric Monk almost 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit ea4a67f462de0a39a9adea8197bcdef849de5371

commit  ea4a67f462de0a39a9adea8197bcdef849de5371
Author: Matthew Ahrens <mahrens@delphix.com>
Date:   2016-05-19T14:43:15.000Z

    6980 6902 causes zfs send to break due to 32-bit/64-bit struct mismatch
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF