Actions
Bug #7043
closed
endian.h uses bad macros for _BIG_ENDIAN
Start date:
2016-06-05
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
On the SPARC build it was observed that the endian.h changes were breaking. This is due to a bad use of the pre-processor. In the else cases for _BIG_ENDIAN we incorrectly use a #elif _BIG_ENDIAN without correctly asking it it's defined. This changes all the use of the pre-processor bits in endian.h and its tests to use defined().
Related issues
Updated by Robert Mustacchi over 7 years ago
- Related to Bug #7142: build failed on sparc after endian integration added
Updated by Electric Monk over 7 years ago
- Status changed from New to Closed
git commit cc366bfc297550eb10cd5f677d98c8d206eca4f1
commit cc366bfc297550eb10cd5f677d98c8d206eca4f1
Author: Robert Mustacchi <rm@joyent.com>
Date: 2016-07-22T16:02:18.000Z
7038 users of endian.h expect __ prefixed versions of macros
7043 endian.h uses bad macros for _BIG_ENDIAN
Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
Reviewed by: Richard PALO <richard@netbsd.org>
Approved by: Dan McDonald <danmcd@omniti.com>
Actions