Project

General

Profile

Actions

Bug #707

closed

sata framework is unsure of bitwise ops

Added by Rich Lowe almost 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
kernel
Start date:
2011-02-08
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Searching for typoed boolean ops in place of bitwise:

source:usr/src/uts/common/io/sata/impl/sata.c@13283#L8110 if (sata_id->ai_cap && SATA_STANDBYTIMER) {
source:usr/src/uts/common/io/sata/impl/sata.c@13283#L8516: (!(sata_id->ai_cap && SATA_STANDBYTIMER) && page->standby 1)) {
source:usr/src/uts/common/io/sata/impl/sata.c@13283#L12282: pmport) && SATA_VALID_DEV_TYPE) 0) {

All look incorrect.

Actions #1

Updated by Garrett D'Amore over 10 years ago

  • Status changed from New to Resolved
  • Difficulty set to Medium
  • Tags set to needs-triage

This was resolved a while ago in:

changeset: 13336:194dde734096
user: Garrett D'Amore <>
date: Mon Apr 11 12:15:48 2011 -0700
description:
707 sata framework is unsure of bitwise ops
Reviewed by: Dan McDonald <>
Reviewed by: Albert Lee <>
Reviewed by: Roland Mainz <>
Reviewed by: Richard Elling <>
Approved by: Albert Lee <>

Actions

Also available in: Atom PDF