Project

General

Profile

Bug #711

smb_rename has its bitwise ops muddled

Added by Rich Lowe about 10 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
2011-02-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Tags:
Gerrit CR:

Description

Searching for typoed boolean ops in place of bitwise:

source:usr/src/uts/common/fs/smbsrv/smb_rename.c@13283#L441: if (!(sr->arg.dirop.flags && SMB_RENAME_FLAG_OVERWRITE)) {

Is bogus

#1

Updated by Gordon Ross almost 10 years ago

  • Assignee set to Aram H?v?rneanu
#3

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 5255b2c28ca5f82d05860cbfd284950e01aa76f7

commit  5255b2c28ca5f82d05860cbfd284950e01aa76f7
Author: Aram Hăvărneanu <aram@nexenta.com>
Date:   2018-08-19T06:44:21.000Z

    711 smb_rename has its bitwise ops muddled
    Reviewed by: Gordon Ross <gwr@nexenta.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Ken Mays <kmays2000@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF