Project

General

Profile

Actions

Bug #7112

open

ixgbe can busy-wait for (many) milliseconds at a time

Added by Chris Siebenmann over 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2016-06-14
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

The ixgbe driver core code has a number of places that call msec_delay() to wait for some number of milliseconds (hard-coded waits are up to 100 msec); see eg usr/src/uts/common/io/ixgbe/core/ixgbe_common.c in ixgbe_check_mac_link_generic(). Unfortunately, in ixgbe_osdep.h the driver code #defines msec_delay() to be:

#define   msec_delay(x)           drv_usecwait(x * 1000)

drv_usecwait() busy-waits for the stated time, which means that ixgbe can busy-wait for millisecond(s) at a time.

(It seems likely that converting this to use delay(9f) instead would be appropriate.)

No data to display

Actions

Also available in: Atom PDF