Actions
Bug #7118
opencstyle issues encountered in mechglueP.h
Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2016-06-18
Due date:
% Done:
0%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:
Description
as discussed during the review of il_6615, there are some cstyle issues encountered that
output 1) 'unary * followed by space' or 2) 'continuation line should be indented by 4 spaces'
warnings that don't seem justified.
1) is of the form (lines 186:192)
OM_uint32 (*gss_release_cred) ( void *, /* context */ OM_uint32 *, /* minor_status */ gss_cred_id_t * /* cred_handle */ /* */);
2) between lines 613 and 627, where
OM_uint32 gss_add_mech_name_type( OM_uint32 *, /* minor_status */ gss_OID, /* name_type */ gss_OID /* mech */ );
is okay, but the following with the return type on a previous line isn't
OM_uint32 gssint_mech_to_oid( const char *mech, /* mechanism string name */ gss_OID *oid /* mechanism oid */ );
unless the style guide explicitly disallows this latter form in function declarations.
attached is a diff of mechglueP.h leaving only these issues, plus
a copy of the output from cstyle -cpPv mechglueP.h.
Files
No data to display
Actions