Project

General

Profile

Actions

Bug #7152

closed

weird condition in arn(7D) needs clarification

Added by Rich Lowe over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2016-06-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

arn(7D) contains the condition
if (!on != aniState->ofdmWeakSigDetectOff) {

Seemingly intentionally. Parenthesizing the !on clarifies the intent at complementing it and pacifies the compiler, though it's still ugly.

Actions #1

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit fd7c59804fad02c3863ef57c544fa7af0fd35068

commit  fd7c59804fad02c3863ef57c544fa7af0fd35068
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2016-07-06T22:18:52.000Z

    7154 arn(7D) walks out of bounds when byteswapping the 4K eeprom
    7152 weird condition in arn(7D) needs clarification
    7153 delete unused code in arn(7D)
    7155 arn(7D) should include the mac fields in the eeprom enumeration
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF