Actions
Bug #7159
closedlibc-tests build failed on sparc
Start date:
2016-07-01
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
Description
+ /opt/gcc/4.4.4/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -mno-integer-ldd-std -D__sun -fno-strict-aliasing -fno-unit-at-a-time -fno-optimize-sibling-calls -O2 -m32 -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -std=gnu89 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -DTEXT_DOMAIN="SUNW_OST_OSCMD" -D_TS_ERRNO -I/code/illumos-gate/proto/root_sparc/usr/include -D_REENTRANT -Wl,-Bdirect -Wl,-M/code/illumos-gate/usr/src/common/mapfiles/common/map.noexstk -Wl,-M/code/illumos-gate/usr/src/common/mapfiles/common/map.pagealign -o pthread_attr_get_np pthread_attr_get_np.c -L/code/illumos-gate/proto/root_sparc/lib -L/code/illumos-gate/proto/root_sparc/usr/lib -mcpu=v8 -mno-v8plus -lc
pthread_attr_get_np.c: In function 'pgn_verif_thr_stack':
pthread_attr_get_np.c:98: error: 'mcontext_t' has no member named '__gregs'
pthread_attr_get_np.c: In function 'pgn_verif_thr_stack':
pthread_attr_get_np.c:98: error: 'mcontext_t' has no member named '__gregs'
- Error code 1
dmake: Fatal error: Command failed for target `pthread_attr_get_np'
Current working directory /data/code/illumos-gate/usr/src/test/libc-tests/tests/threads
__gregs defined in /usr/include/sys/regset.h
Updated by Igor Kozhukhov almost 6 years ago
i have fixed it and pointed on IRC to this mistake:
diff --git a/usr/src/test/libc-tests/tests/threads/pthread_attr_get_np.c b/usr/src/test/libc-tests index 71a58c3..4713240 100644 --- a/usr/src/test/libc-tests/tests/threads/pthread_attr_get_np.c +++ b/usr/src/test/libc-tests/tests/threads/pthread_attr_get_np.c @@ -75,10 +75,6 @@ static pthread_attr_t pgn_attr; static pthread_attr_t pgn_thr_attr; static pthread_barrier_t pgn_barrier; -#ifdef __sparc -#define gregs __gregs -#endif - /* * Verify that the stack pointer of a context is consistent with where the * attributes indicate. @@ -100,10 +96,6 @@ pgn_verif_thr_stack(pthread_attr_t *attr) VERIFY3U(sp, <, (uintptr_t)stk + stksz); } -#ifdef __sparc -#undef gregs -#endif - static void pgn_test_fini(void) {
Updated by Alexander Eremin almost 6 years ago
Igor Kozhukhov wrote:
i have fixed it and pointed on IRC to this mistake:
[...]
Yes, fix is simple.
Updated by Alexander Eremin almost 6 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 50
Updated by Electric Monk almost 6 years ago
- Status changed from In Progress to Closed
- % Done changed from 50 to 100
git commit 0cc4b3ed113ebd5447f33e18c4a6323f75aa1fe5
commit 0cc4b3ed113ebd5447f33e18c4a6323f75aa1fe5 Author: Alexander Eremin <a.eremin@nexenta.com> Date: 2016-08-06T16:21:48.000Z 7159 libc-tests build failed on sparc Reviewed by: Richard Lowe <richlowe@richlowe.net> Reviewed by: Robert Mustacchi <rm@joyent.com> Approved by: Robert Mustacchi <rm@joyent.com>
Actions