Project

General

Profile

Actions
Copy link

Bug #7198

closed

libzfs should gracefully handle EINVAL from lzc_rollback

Added by Andriy Gapon almost 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2016-07-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

EINVAL is returned when a dataset does not have any snapshots, so there is nothing to roll back to.
Although the code in zfs_do_rollback checks for that condition in advance, it's still possible that the snapshot(s) gets removed after the check and before the rollback sync task is executed.
At the moment zfs command would crash when that happens.

Related issues

Related to illumos gate - Bug #8520: lzc_rollback_to should support rolling back to originClosed2017-07-21

Actions
Actions
Copy link
 #1

Updated by Andriy Gapon almost 5 years ago

  • Related to Bug #8520: lzc_rollback_to should support rolling back to origin added
Actions
Copy link
 #2

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 95643f75d23914a3e332adc9661ed51749e9858d

commit  95643f75d23914a3e332adc9661ed51749e9858d
Author: Andriy Gapon <avg@FreeBSD.org>
Date:   2018-02-08T05:16:38.000Z

    8520 lzc_rollback_to should support rolling back to origin
    7198 libzfs should gracefully handle EINVAL from lzc_rollback
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF