Project

General

Profile

Actions

Bug #7205

closed

trap() acquires p_lock unnecessarily

Added by Robert Mustacchi almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
2016-07-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

In looking at a machine running Couchbase, lock contention was modestly high on p_lock. The major source of p_lock acquisition was trap(), from the TP_CHANGEBIND case. This should act as other code paths do and only acquire this lock if the flag is set – and then recheck it under the lock.

Actions #1

Updated by Electric Monk almost 6 years ago

  • Status changed from New to Closed

git commit 7429414e8ece9246bddb63c2875c9d54b50caa12

commit  7429414e8ece9246bddb63c2875c9d54b50caa12
Author: Bryan Cantrill <bryan@joyent.com>
Date:   2016-08-07T01:19:02.000Z

    7205 trap() acquires p_lock unnecessarily
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF