Project

General

Profile

Actions
Copy link

Bug #7220

closed

devfs_clean() callers shouldn't rely on its return value

Added by Yuri Pankov almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
kernel
Start date:
2016-07-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Apparently, some of devfs_clean() callers aren't aware of the following change, which made devfs_clean() always return 0, and still try to make decisions based on its return value:

commit 19174f18ff621e2acd8b3e8f6a9504a68e5fd8f7
Author: vikram <none@none>
Date:   Thu Jun 7 14:31:57 2007 -0700

    6565553 devfs_clean() should not be used to test for offlinability

Actions
Copy link
 #1

Updated by Yuri Pankov almost 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk almost 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit cfc3b49fd53fba13be205e2206e0ea3b36f5f2c7

commit  cfc3b49fd53fba13be205e2206e0ea3b36f5f2c7
Author: Yuri Pankov <yuri.pankov@nexenta.com>
Date:   2016-08-11T14:38:28.000Z

    7220 devfs_clean() callers shouldn't rely on its return value
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF