Project

General

Profile

Bug #7230

add assertions to dmu_send_impl() to verify that stream includes BEGIN and END records

Added by Daniel Kimmel about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2016-07-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

A test failure occurred where a send stream had only a BEGIN record. This should not be possible if the send returns without error. Prevented this from happening in the future by adding an assertion to dmu_send_impl() to verify that if the function returns 0 (success) both a BEGIN and END record are present. Did this by adding flags to dmu_sendarg_t (indicating whether BEGIN or END records sent), having dump_record() set flags appropriately, adding VERIFY statement to dmu_send_impl().

History

#1

Updated by Electric Monk about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 12b90ee2d3b10689fc45f4930d2392f5fe1d9cfa

commit  12b90ee2d3b10689fc45f4930d2392f5fe1d9cfa
Author: Matt Krantz <matt.krantz@delphix.com>
Date:   2016-08-02T16:54:36.000Z

    7230 add assertions to dmu_send_impl() to verify that stream includes BEGIN and END records
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF