add assertions to dmu_send_impl() to verify that stream includes BEGIN and END records
A test failure occurred where a send stream had only a BEGIN record. This should not be possible if the send returns without error. Prevented this from happening in the future by adding an assertion to dmu_send_impl() to verify that if the function returns 0 (success) both a BEGIN and END record are present. Did this by adding flags to dmu_sendarg_t (indicating whether BEGIN or END records sent), having dump_record() set flags appropriately, adding VERIFY statement to dmu_send_impl().
Updated by Electric Monk about 4 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 12b90ee2d3b10689fc45f4930d2392f5fe1d9cfa Author: Matt Krantz <firstname.lastname@example.org> Date: 2016-08-02T16:54:36.000Z 7230 add assertions to dmu_send_impl() to verify that stream includes BEGIN and END records Reviewed by: Matthew Ahrens <email@example.com> Reviewed by: Paul Dagnelie <firstname.lastname@example.org> Reviewed by: Igor Kozhukhov <email@example.com> Approved by: Robert Mustacchi <firstname.lastname@example.org>