Project

General

Profile

Bug #7234

check for empty column strings in svcs

Added by Daniel Kimmel about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Kimmel
Category:
smf
Start date:
2016-07-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

The code assumes that there is always at least one column specified when the command line options asked for specific columns. If the user passed an empty string, a segfault resulted. This change detects the empty string and throws an appropriate error.

History

#1

Updated by Electric Monk about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit be1977d8f5897cf3f531fa59cd0e40fc5c03bcb4

commit  be1977d8f5897cf3f531fa59cd0e40fc5c03bcb4
Author: Nathan Burnett <nathan.burnett@delphix.com>
Date:   2016-08-02T16:49:32.000Z

    7234 check for empty column strings in svcs
    Reviewed by: Sebastien Roy <sebastien.roy@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Matthew Ahrens <mahrens@delphix.com>

Also available in: Atom PDF