Project

General

Profile

Bug #7261

nvlist code should enforce name length limit

Added by Prakash Surya about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2016-08-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

The nvlist/nvpair code stores the name length in a int16_t, therefore supporting names of up to 2^15 bytes. However, it does not enforce this, so if you pass a longer name, it will be silently truncated. The nvlist code should instead return an error.

History

#1

Updated by Electric Monk about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 48dd5e630c9b1773b7b10d08a3b90b6c9062d713

commit  48dd5e630c9b1773b7b10d08a3b90b6c9062d713
Author: Matthew Ahrens <mahrens@delphix.com>
Date:   2016-08-05T15:14:22.000Z

    7261 nvlist code should enforce name length limit
    Reviewed by: Sebastien Roy <sebastien.roy@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF