Project

General

Profile

Actions

Bug #7272

closed

nvme_reg_csts_t is not correctly defined in nvme_reg.h

Added by Youzhong Yang almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
driver - device drivers
Start date:
2016-08-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

It's now defined as

typedef union {
struct {
uint32_t csts_rdy:1; /* Ready /
uint32_t csts_cfs:1; /
Controller Fatal Status /
uint32_t csts_shst:2; /
Shutdown Status /
uint32_t csts_nssro:1; /
NVM Subsystem Reset Occured */
uint32_t csts_rsvd:28;
} b;
uint32_t r;
} nvme_reg_csts_t;

but csts_rsvd field should be 27 bits.

Actions #1

Updated by Rich Lowe almost 5 years ago

This is the ultimate cause of the funny CTF issue Igor and Robert had, too. (I thought the size seemed odd. Guess I should have checked the spec!)

Actions #2

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 62c767e5250dc15fcd09bd265883d3e2fe4b3c2d

commit  62c767e5250dc15fcd09bd265883d3e2fe4b3c2d
Author: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Date:   2016-08-10T15:04:59.000Z

    7272 nvme_reg_csts_t is not correctly defined in nvme_reg.h
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Dan Fields <dan.fields@nexenta.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF