Project

General

Profile

Actions

Bug #7294

closed

several small nvme fixes from Tegile

Added by Hans Rosenfeld almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
2016-08-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Tegile sent me a handful of small nvme fixes for obvious botches:
  • test against n_ignore_unknown_vendor_status in nvme_check_vendor_cmd_status() should be inverted
  • in nvme_set_nqueues(), value of nqueues is 0-based
  • in nvme_init(), need to set the size of the SQ and CQ entries for the NVM command set; D3700 fails I/O Q creation otherwise
  • in nvme_init(), when releasing unused interrupts, s/nqueues/nvme_n_ioq_count/ in the call to nvme_setup_interrupts()
  • in nvme_get_logpage(), initialize getlogpage union zero; D3700 barfs on non-zero reserved fields
Actions #1

Updated by Hans Rosenfeld almost 5 years ago

  • Subject changed from several small nvme fixes from Tegile to several small nvme fixes from Tegile
Actions #2

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 34c938c74e6f278ee870d39330b571ffea1b808e

commit  34c938c74e6f278ee870d39330b571ffea1b808e
Author: Pete Shephard <pete.shephard@tegile.com>
Date:   2016-08-25T15:04:44.000Z

    7294 several small nvme fixes from Tegile
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Reviewed by: Dan Fields <dan.fields@nexenta.com>
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions

Also available in: Atom PDF