Project

General

Profile

Actions

Bug #7298

closed

printa() of multiple aggregations can fail for llquantize()

Added by Robert Mustacchi almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Category:
DTrace
Start date:
2016-08-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

In fixing 7297 and searching for all uses of DTRACEAGG_LQUANTIZE and making sure that there was correct handling for DTRACEAGG_LLQUANTIZE, it was clear that there was another bug; take the following:

BEGIN
{
    @a["i"] = llquantize(10, 10, 0, 6, 20);
    @b["suck"] = count();
    printa(@a, @b);
    exit(0);
}

Running this D script induces death in DTrace:

CPU     ID                    FUNCTION:NAME
  0      1                           :BEGIN 
Arithmetic Exception (core dumped)

Related issues

Related to illumos gate - Bug #7297: clear() on llquantize aggregation causes dtrace to exitClosedBryan Cantrill2016-08-13

Actions
Actions #1

Updated by Robert Mustacchi almost 5 years ago

  • Related to Bug #7297: clear() on llquantize aggregation causes dtrace to exit added
Actions #2

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed

git commit 0ddc0ebb74cedb0ac394818c6e166c47eb8e62e5

commit  0ddc0ebb74cedb0ac394818c6e166c47eb8e62e5
Author: Bryan Cantrill <bryan@joyent.com>
Date:   2016-08-25T23:32:27.000Z

    7297 clear() on llquantize aggregation causes dtrace to exit
    7298 printa() of multiple aggregations can fail for llquantize()
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Adam Leventhal <adam.leventhal@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF