Bug #7320

Update failed following Sun SSH deprecation

Added by Espen Martinsen over 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:2016-08-23
Priority:NormalDue date:
Assignee:OI Userland% Done:

0%

Category:OI-Userland
Target version:Hipster
Difficulty:Medium Tags:needs-triage

Description

last update: 20160811 (uname -a: SunOS esmpc 5.11 illumos-1dcf899 i86pc i386 i86pc Solaris)

$ pfexec pkg image-update --be-name OIhipster-20160823

Creating Plan (Solver setup): \

Packages to remove:   2
           Packages to install:   5
            Packages to update: 402
            Packages to change:   2
           Mediators to change:   1
       Create boot environment: Yes
Create backup boot environment:  No

DOWNLOAD PKGS FILES XFER (MB) SPEED
Completed 411/411 4992/4992 421.1/421.1 6.0M/s

PHASE ITEMS
Removing old actions 2479/2479
Installing new actions 2380/2380
Updating modified actions 2162/5488Action upgrade failed for 'etc/ssh/sshd_config' (pkg://openindiana.org/service/network/ssh):
TypeError: 'NoneType' object is not callable

The running system has not been modified. Modifications were only made to a clone of the running system. This clone is mounted at /tmp/tmpTwy6HY should you wish to inspect it.
Traceback (most recent call last):
File "/usr/bin/pkg", line 5444, in handle_errors
__ret = func(*args, **kwargs)
File "/usr/bin/pkg", line 5430, in main_func
pargs=pargs, **opts)
File "/usr/bin/pkg", line 2116, in update
display_plan_cb=display_plan_cb, logger=logger)
File "/usr/lib/python2.7/vendor-packages/pkg/client/client_api.py", line 1600, in _update
logger=logger)
File "/usr/lib/python2.7/vendor-packages/pkg/client/client_api.py", line 1476, in __api_op
ret = __api_execute_plan(_op, _api_inst)
File "/usr/lib/python2.7/vendor-packages/pkg/client/client_api.py", line 1028, in __api_execute_plan
api_inst.execute_plan()
File "/usr/lib/python2.7/vendor-packages/pkg/client/api.py", line 2825, in execute_plan
self._img.imageplan.execute()
File "/usr/lib/python2.7/vendor-packages/pkg/client/imageplan.py", line 4613, in execute
p.execute_update(src, dest)
File "/usr/lib/python2.7/vendor-packages/pkg/client/pkgplan.py", line 582, in execute_update
dest.install(self, src)
File "/usr/lib/python2.7/vendor-packages/pkg/actions/file.py", line 189, in install
stream = self.data()
TypeError: 'NoneType' object is not callable

pkg: This is an internal error in pkg(5) version 33d20ff. Please log a
Service Request about this issue including the information above and this
message.

History

#1 Updated by Espen Martinsen over 2 years ago

fix:
$ pfexec beadm unmount OIhipster-20160823
$ pfexec beadm destroy OIhipster-20160823
$ pfexec pkg uninstall pkg://openindiana.org/network/ssh
$ pfexec pkg uninstall pkg://openindiana.org/service/network/ssh

$ pfexec pkg image-update --be-name OIhipster-20160823
Packages to remove: 2
Packages to install: 7
Packages to update: 400
Packages to change: 2
Mediators to change: 1
Create boot environment: Yes
Create backup boot environment: No

DOWNLOAD PKGS FILES XFER (MB) SPEED
Completed 411/411 4980/4980 419.7/419.7 1.8k/s

PHASE ITEMS
Removing old actions 2408/2408
Installing new actions 2401/2401
Updating modified actions 5463/5463
Updating package state database Done
Updating package cache 402/402
Updating image state Done
Creating fast lookup database Done

A clone of OIhipster-20160811 exists and has been updated and activated.
On the next boot the Boot Environment OIhipster-20160823 will be
mounted on '/'. Reboot when ready to switch to this updated BE.

---------------------------------------------------------------------------
NOTE: Please review release notes posted at:

http://wiki.openindiana.org/display/oi/oi_hipster
---------------------------------------------------------------------------

#2 Updated by Espen Martinsen over 2 years ago

Hi,
forgot to mention, I'm running openssh

$ nc localhost 22
SSH-2.0-OpenSSH_7.2

#3 Updated by Aurélien Larcher over 2 years ago

  • Subject changed from update failed to Update failed following Sun SSH deprecation
  • Target version set to Hipster
  • Category changed from Release Engineering to OI-Userland
  • Assignee set to OI Userland

#4 Updated by Alexander Pyhalov over 2 years ago

Hi, do you have old BE (before update)?

#5 Updated by Alexander Pyhalov over 2 years ago

Can you show
ls -l /etc/ssh/sshd_config in original BE (before update)?

#6 Updated by Espen Martinsen over 2 years ago

Hi, yes, they are exactly the same:

  1. zfs set mountpoint=/a rpool/ROOT/OIhipster-20160823-backup-1
  2. zfs mount rpool/ROOT/OIhipster-20160823-backup-1

$ ls l /a/etc/ssh/sshd_config /etc/ssh/sshd_config
-rw-r--r- 1 root bin 4609 Aug 23 18:26 /a/etc/ssh/sshd_config
rw-r--r- 1 root bin 4609 Aug 23 18:26 /etc/ssh/sshd_config

#7 Updated by Alexander Pyhalov over 2 years ago

Can you test the following:
1) create new BE from affected BE (which can't be updated)
2) boot it
3) pkg change-facet facet.version-lock.package/pkg=true=false
4) Install pkg://userland/package/,5.11-2016.0.0.5182:20160824T114645Z from http://buildzone.oi-build.r61.net:1000/
5) try updating again
?

#9 Updated by Espen Martinsen over 2 years ago

Verified!
$pfexec beadm create -a -e OIhipster-20160823-backup-1 -v myTestBE
$reboot
....
$ uname -a
SunOS esmpc 5.11 illumos-1dcf899 i86pc i386 i86pc Solaris

#pkg change-facet facet.version-lock.package/pkg=false
#pkg install -g http://buildzone.oi-build.r61.net:1000/ pkg://userland/package/,5.11-2016.0.0.5182:20160824T114645Z

#pkg image-update --be-name OIhipster-updatetest

-> OK

Thanks Alexander!

#10 Updated by Alexander Pyhalov over 2 years ago

  • Status changed from Resolved to In Progress

#11 Updated by Alexander Pyhalov over 2 years ago

We need some instructions on updating from earlier versions

#12 Updated by Alexander Pyhalov over 2 years ago

Workaround: add empty line to /etc/ssh/sshd_config

#13 Updated by Alexander Pyhalov almost 2 years ago

  • Status changed from In Progress to Closed

We ship IPS version which doesn't have this problem. Unfortunately, older installations should use workaround - modify /etc/ssh/ssh_config. We can't fix it.

Also available in: Atom