Project

General

Profile

Bug #7349

nvme shouldn't ignore namespaces that support extended data LBAs

Added by Hans Rosenfeld over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
2016-09-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

The nvme driver currently ignores namespaces that have at least one of the following properties:

  • use thin provisioning
  • support extended data LBAs
  • use protection information

Extended data LBAs are blocks that have protection information at the end, meaning they are a few bytes larger than normal blocks of 512 or 4096 bytes length. It turns out that the capability of a namespace to support these extended data LBAs doesn't mean we actually have to support them: the critical part is whether protection information is enabled on the namespace.

So we can drop the check for extended data LBAs and be able to use namespaces that support them, provided that they still aren't formatted for protection information.

This was found on Samsung PM1725 SSDs, which report to support extended data LBAs on their namespace but have no protection information enabled.

History

#1

Updated by Electric Monk over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 9cfb65faacc43d80fb0e3cc182d2dae107cdf60c

commit  9cfb65faacc43d80fb0e3cc182d2dae107cdf60c
Author: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Date:   2016-09-01T15:31:49.000Z

    7349 nvme shouldn't ignore namespaces that support extended data LBAs
    Reviewed by: Dan Fields <dan.fields@nexenta.com>
    Reviewed by: Rick McNeal <rick.mcneal@nexenta.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF