Project

General

Profile

Bug #7359

NULL pointer at strcmp() in ipmgmt_nvlist_match()

Added by Igor Kozhukhov about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
2016-09-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

we need compare 2 nvlists in ipmgmt_nvlist_match where we have no '_protocol' property for line like:
_aobjname=lo0/v4;_ifname=lo0;_lifnum=0;_family=2;_flags=1;_atype=1;_addr=;

we should check NULL for proto and db_proto before pass arguments to strcmp()
also, need update others checks too.
i'd like propose update strcmp -> strncmp

History

#1

Updated by Igor Kozhukhov about 3 years ago

  • Subject changed from NULL pointer in strcmp in ipmgmt_nvlist_match() to NULL pointer at strcmp() in ipmgmt_nvlist_match() and ipmgmt_nvlist_intersects()
  • Description updated (diff)
#2

Updated by Igor Kozhukhov about 3 years ago

  • Subject changed from NULL pointer at strcmp() in ipmgmt_nvlist_match() and ipmgmt_nvlist_intersects() to NULL pointer at strcmp() in ipmgmt_nvlist_match()
#3

Updated by Electric Monk about 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit c985e172447301fefddd2d30ac4cb0cac2281d0c

commit  c985e172447301fefddd2d30ac4cb0cac2281d0c
Author: Igor Kozhukhov <igork@argotech.io>
Date:   2016-09-07T17:00:34.000Z

    7359 NULL pointer at strcmp() in ipmgmt_nvlist_match()
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF