could be more forgiving of bad smbios tables
On Lenovo x3650 and x3550 M5s (at least), the last item in the smbios table runs past the end of the table, which causes smbios_bufopen to fail, setting the error to ESMB_CORRUPT. The last item is some vendor-specific thing that no one needs to look at, so it seems a bit unnecessary to deem the entire table corrupt as a result.
For comparison, Linux just ignores the item in this case, and OpenBSD doesn't even look at it, as it stops scanning the table when it finds the entry it wants.
Updated by Electric Monk almost 3 years ago
- % Done changed from 0 to 100
- Status changed from New to Closed
commit 516627f338a630bcf9806a91aa873bbbae9a2fac Author: Jonathan Matthew <firstname.lastname@example.org> Date: 2016-10-20T22:34:17.000Z 7360 could be more forgiving of bad smbios tables Reviewed by: Robert Mustacchi <email@example.com> Reviewed by: Dan McDonald <firstname.lastname@example.org> Reviewed by: Hans Rosenfeld <email@example.com> Approved by: Gordon Ross <firstname.lastname@example.org>