Project

General

Profile

Bug #7398

zfs test zfs_get_005_neg does not work as expected

Added by Marcel Telka almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tests
Start date:
2016-09-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

The zfs_get_005_neg test does not work as expected for several reasons:

  1. The val_props variable is incorrectly defined as val_pros (note missing p),
  2. The val_proPs variable contains double dash (--) as the first member. Since the val_proPs content is shuffled to get the actual random list of properties the double dash won't stay first and it will be intermixed with the (valid) properties. The double dash should be moved to the actual zfs command call to explicitly separate the options and the properties list. The double dash separation is especially needed for invalid properties (in inval_props and inval_props_str) because those contains properties starting with a dash (like -on and --on).
  3. The val_props_str contains -a and -d. Both are not the valid properties and they should be removed from val_props_str.

History

#1

Updated by Marcel Telka almost 3 years ago

  • Status changed from In Progress to Pending RTI
#2

Updated by Electric Monk almost 3 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit 4220fdc152e5dfec9a1dd51452175295f3684689

commit  4220fdc152e5dfec9a1dd51452175295f3684689
Author: Marcel Telka <marcel@telka.sk>
Date:   2016-09-23T17:58:59.000Z

    7398 zfs test zfs_get_005_neg does not work as expected
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: John Kennedy <john.kennedy@delphix.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF