Project

General

Profile

Bug #7406

illumos-gate fails to build with CUPS 1.7

Added by Alexander Pyhalov over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2016-09-26
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

After updating cups we experience issue with illumos-gate build:

 /opt/gcc/4.4.4/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -D__sun -O -m32 -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -Wno-unused -Wno-empty-body -std=gnu99 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -DTEXT_DOMAIN="SUNW_OST_OSCMD" -D_TS_ERRNO -I/usr/include/cups -I/jenkins/jobs/illumos-gate/workspace/components/openindiana/illumos-gate/illumos-gate/proto/root_i386-nd/usr/include -D_REENTRANT -Dsyslog=smb_syslog -I /jenkins/jobs/illumos-gate/workspace/components/openindiana/illumos-gate/illumos-gate/proto/root_i386-nd/usr/include/kerberosv5 -DHAVE_CUPS -c smbd_spool.c 
smbd_spool.c: In function 'smbd_spool_copyfile':
smbd_spool.c:242: error: dereferencing pointer to incomplete type
smbd_spool.c:243: error: dereferencing pointer to incomplete type
smbd_spool.c:294: error: dereferencing pointer to incomplete type

Some cups structures were hidden by _IPP_PRIVATE_STRUCTURES define.
The following patch fixes the issue:

diff --git a/usr/src/cmd/smbsrv/smbd/Makefile b/usr/src/cmd/smbsrv/smbd/Makefile
index eaa86dc..7af39ef 100644
--- a/usr/src/cmd/smbsrv/smbd/Makefile
+++ b/usr/src/cmd/smbsrv/smbd/Makefile
@@ -61,6 +61,7 @@ LINTFLAGS += -xerroff=E_NAME_DEF_NOT_USED2
 LINTFLAGS += -xerroff=E_NAME_USED_NOT_DEF2

 CFLAGS += $(CCVERBOSE)
+CPPFLAGS += -D_IPP_PRIVATE_STRUCTURES
 CPPFLAGS += -D_REENTRANT
 CPPFLAGS += -Dsyslog=smb_syslog
 $(NOT_RELEASE_BUILD)CPPFLAGS += -DDEBUG

#1

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit c7e79765a5bdcd4e6f05ea8effc8c7ce07e8a37a

commit  c7e79765a5bdcd4e6f05ea8effc8c7ce07e8a37a
Author: Alexander Pyhalov <apyhalov@gmail.com>
Date:   2016-09-27T15:47:43.000Z

    7406 illumos-gate fails to build with CUPS 1.7

    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF