Project

General

Profile

Bug #7436

webrev doesn't work if illumos-gate is a submodule

Added by Andrew Stormont about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2016-09-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

webrev sets codemgr_ws incorrectly when illumos-gate is a submodule.

diff --git a/usr/src/tools/scripts/webrev.sh b/usr/src/tools/scripts/webrev.sh
index a404d4d..e6eb21b 100644
--- a/usr/src/tools/scripts/webrev.sh
+++ b/usr/src/tools/scripts/webrev.sh
@@ -27,6 +27,7 @@
 # Copyright 2014 Bart Coddens <bart.coddens@gmail.com>
 # Copyright 2016 Nexenta Systems, Inc.
 # Copyright 2016 Joyent, Inc.
+# Copyright 2016 RackTop Systems.
 #

 #
@@ -2362,7 +2363,9 @@ elif [[ $SCM_MODE == "git" ]]; then
                codemgr_ws="${PWD}/${codemgr_ws}" 
        fi

-       codemgr_ws=$(dirname $codemgr_ws) # Lose the '/.git'
+       if [[ "$codemgr_ws" = *"/.git" ]]; then
+               codemgr_ws=$(dirname $codemgr_ws) # Lose the '/.git'
+       fi
        CWS="$codemgr_ws" 
 elif [[ $SCM_MODE == "subversion" ]]; then
        #

History

#1

Updated by Andrew Stormont about 3 years ago

This results in the generated filelist being empty and every webrev containing no changes.

#3

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e2004245d6147c5747ca68584835573d99d469d9

commit  e2004245d6147c5747ca68584835573d99d469d9
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2017-01-30T17:22:19.000Z

    7436 webrev doesn't work if illumos-gate is a submodule
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF