Project

General

Profile

Actions
Copy link

Bug #7440

closed

loader cd9660_open should check for padding

Added by Toomas Soome almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
2016-09-30
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

I have "buggy" iso, where there is no /boot/loader.conf file, but loader
does not fail with file not found, but instead, it does open
/boot/defaults/loader.conf.

While investigating I found:

the directory extent for /boot is 4096 bytes
the last file in directory, /boot/zfsloader, ends at extent offset 2048.
the next entry has length 0 (and in fact, all the directory entry is zero).

So we have hit the corner case with second half of the directory extent is
actually padding.

FreeBSD issue: https://reviews.freebsd.org/D8101

Actions
Copy link
 #1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 472d57724271fcaa87b37d98016e1a239f0b6e84

commit  472d57724271fcaa87b37d98016e1a239f0b6e84
Author: Toomas Soome <tsoome@me.com>
Date:   2016-10-07T16:29:48.000Z

    7440 loader cd9660_open should check for padding
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Jörg Schilling <Joerg.Schilling@fokus.fraunhofer.de>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF