Project

General

Profile

Bug #7475

savecore should not go further if there is no dumpfile

Added by Alexander Eremin over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
2016-10-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

if dumpfile/dumpdevice doesn't exist, savecore call logprint, which call raise_event, which tries to open dumpfile, fails and call logprint again:

# savecore -f foo
savecore: stat(“foo”): No such file or directory
savecore: open(“foo”): No such file or directory
# dumpadm -d none
Dump content: kernel pages
Dump device: none (swap)
Savecore directory: /var/crash/nef
Savecore enabled: yes
Save compressed: on
~# savecore -L
savecore: no dump device configured
savecore: open(""): No such file or directory

savecore must exit in first iteration instead.

History

#1

Updated by Electric Monk over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Closed

git commit 222d1ab6ac935b870bc344025f6ac3e0613e2940

commit  222d1ab6ac935b870bc344025f6ac3e0613e2940
Author: Alexander Eremin <a.eremin@nexenta.com>
Date:   2016-10-25T14:53:41.000Z

    7475 savecore should not go further if there is no dumpfile
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF